----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1816/#review4530 -----------------------------------------------------------
Ship it! Thanks! Looks great - Andreas Hansson On July 17, 2013, 7:54 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1816/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 7:54 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9812:ddc50e6eae13 > --------------------------- > Configs: Fix up maxtick and maxtime > > This patch contains three fixes to max tick options handling in Options.py and > Simulation.py: > > 1) Since the global simulator frequency isn't bound until m5.instantiate() > is called, the maxtick resolution needs to happen after this call, since > changes to the global frequency will cause m5.simulate() to misinterpret the > maxtick value. Shuffling this also requires tweaking the checkpoint directory > handling to signal the checkpoint restore tick back to run(). Fixing this > completely and correctly will require storing the simulation frequency into > checkpoints, which is beyond the scope of this patch. > > 2) The maxtick option in Options.py was defaulted to MaxTicks, so the old > code > would always skip over the maxtime part of the conditionals at the beginning > of run(). Change the maxtick default to None, and set the maxtick local > variable in run() appropriately. > > 3) To clarify whether max ticks settings are relative or absolute, split the > maxtick option into separate options, for relative and absolute. Ensure that > these two options and the maxtime option are handled appropriately to set the > maxtick variable in Simulation.py. > > > Diffs > ----- > > configs/common/Options.py e895db06e69f > configs/common/Simulation.py e895db06e69f > > Diff: http://reviews.gem5.org/r/1816/diff/ > > > Testing > ------- > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
