> On Aug. 6, 2013, 11:49 a.m., Andreas Hansson wrote: > > src/cpu/simple/atomic.cc, line 178 > > <http://reviews.gem5.org/r/1953/diff/1/?file=36681#file36681line178> > > > > Why the ++ and -- when all we want is 1 and 0. > > > > I'd suggest notIdleFraction = 0 and notIdleFraction = 1 where ever it > > says -- and ++ at the moment.
I kept the ++ and -- for consistency with the other updates to the stat, but I agree that setting to 1 and 0 makes far more sense. I'll change all occurrences as you suggest. - Lena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1953/#review4574 ----------------------------------------------------------- On Aug. 7, 2013, 8:24 p.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1953/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 8:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9811:07db1338d0b2 > --------------------------- > cpu: accurately count idle cycles for simple cpu > > Added a couple missing updates to the notIdleFraction stat. Without these, it > sometimes gives a (not) idle fraction that is greater than 1 or less than 0. > > > Diffs > ----- > > src/cpu/ozone/cpu_impl.hh e895db06e69f > src/cpu/simple/atomic.cc e895db06e69f > src/cpu/simple/timing.cc e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic-dual/simerr > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic-dual/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic-dual/stats.txt > e895db06e69f > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic/simerr > e895db06e69f > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic/stats.txt > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing-dual/simerr > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing-dual/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing-dual/stats.txt > e895db06e69f > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing/simerr > e895db06e69f > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing/stats.txt > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic-dual/simerr > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic-dual/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic-dual/stats.txt > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic-dual/status > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic/simerr > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic/simout > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic/stats.txt > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic/status > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing-dual/simerr > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing-dual/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing-dual/stats.txt > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing-dual/status > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing/simerr > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing/simout > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing/stats.txt > e895db06e69f > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing/status > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-switcheroo-atomic/simerr > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-switcheroo-atomic/simout > e895db06e69f > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-switcheroo-atomic/stats.txt > e895db06e69f > > tests/quick/fs/80.netperf-stream/ref/alpha/linux/twosys-tsunami-simple-atomic/simerr > e895db06e69f > > tests/quick/fs/80.netperf-stream/ref/alpha/linux/twosys-tsunami-simple-atomic/simout > e895db06e69f > > tests/quick/fs/80.netperf-stream/ref/alpha/linux/twosys-tsunami-simple-atomic/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/inorder-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/inorder-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/inorder-timing/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/o3-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/o3-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/o3-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-atomic/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/ruby.stats > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/simerr > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/simout > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/linux/simple-timing/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/o3-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/ruby.stats > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/simerr > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/simout > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing-checker/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing-checker/simout e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing-checker/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/o3-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic-dummychecker/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic-dummychecker/simout > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic-dummychecker/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic/config.ini e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-atomic/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/arm/linux/simple-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/inorder-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/inorder-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/inorder-timing/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/o3-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/o3-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/o3-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-atomic/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-atomic/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/simerr > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/simout > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/mips/linux/simple-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/power/linux/o3-timing/config.ini e895db06e69f > tests/quick/se/00.hello/ref/power/linux/o3-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/power/linux/o3-timing/stats.txt e895db06e69f > tests/quick/se/00.hello/ref/power/linux/simple-atomic/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/power/linux/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/power/linux/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/inorder-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/inorder-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/inorder-timing/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-atomic/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-atomic/simout e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/ruby.stats > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/simerr > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/simout > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/stats.txt > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing/config.ini > e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing/simout e895db06e69f > tests/quick/se/00.hello/ref/sparc/linux/simple-timing/stats.txt > e895db06e69f > tests/quick/se/01.hello-2T-smt/ref/alpha/linux/o3-timing/config.ini > e895db06e69f > tests/quick/se/01.hello-2T-smt/ref/alpha/linux/o3-timing/simout > e895db06e69f > tests/quick/se/01.hello-2T-smt/ref/alpha/linux/o3-timing/stats.txt > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/inorder-timing/config.ini > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/inorder-timing/simerr > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/inorder-timing/simout > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/inorder-timing/stats.txt > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/o3-timing/config.ini > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/o3-timing/simerr e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/o3-timing/simout e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/o3-timing/stats.txt e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-atomic/config.ini > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-atomic/simerr > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-atomic/simout > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-timing/config.ini > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-timing/simerr > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-timing/simout > e895db06e69f > tests/quick/se/02.insttest/ref/sparc/linux/simple-timing/stats.txt > e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-atomic/simerr e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-atomic/simout e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-atomic/stats.txt > e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-timing/simerr e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-timing/simout e895db06e69f > tests/quick/se/20.eio-short/ref/alpha/eio/simple-timing/stats.txt > e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-atomic-mp/simerr e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-atomic-mp/simout e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-atomic-mp/stats.txt > e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-timing-mp/simerr e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-timing-mp/simout e895db06e69f > tests/quick/se/30.eio-mp/ref/alpha/eio/simple-timing-mp/stats.txt > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/o3-timing-mp/config.ini > e895db06e69f > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/o3-timing-mp/simerr > e895db06e69f > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/o3-timing-mp/simout > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/o3-timing-mp/stats.txt > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-atomic-mp/config.ini > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-atomic-mp/simerr > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-atomic-mp/simout > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-atomic-mp/stats.txt > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-timing-mp/config.ini > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-timing-mp/simerr > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-timing-mp/simout > e895db06e69f > > tests/quick/se/40.m5threads-test-atomic/ref/sparc/linux/simple-timing-mp/stats.txt > e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/config.ini > e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/ruby.stats > e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/simout e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/stats.txt > e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest/config.ini e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest/simerr e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest/simout e895db06e69f > tests/quick/se/50.memtest/ref/alpha/linux/memtest/stats.txt e895db06e69f > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/config.ini > e895db06e69f > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/ruby.stats > e895db06e69f > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simerr > e895db06e69f > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simout > e895db06e69f > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/stats.txt > e895db06e69f > tests/quick/se/70.tgen/ref/arm/linux/tgen-simple-dram/simerr e895db06e69f > tests/quick/se/70.tgen/ref/arm/linux/tgen-simple-dram/simout e895db06e69f > tests/quick/se/70.tgen/ref/arm/linux/tgen-simple-dram/stats.txt > e895db06e69f > tests/quick/se/70.tgen/ref/arm/linux/tgen-simple-mem/simout e895db06e69f > tests/quick/se/70.tgen/ref/arm/linux/tgen-simple-mem/stats.txt e895db06e69f > > Diff: http://reviews.gem5.org/r/1953/diff/ > > > Testing > ------- > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
