Hi Lena, I can sort it out and push it. I have some things in the pipeline that change a lot of stats anyhow, so I can add your patch at the end and bump them all together (to keep the changeset size sensible).
Andreas From: Lena Olson <[email protected]<mailto:[email protected]>> Date: Wednesday, August 7, 2013 11:09 PM To: Andreas Hansson <[email protected]<mailto:[email protected]>> Cc: Default <[email protected]<mailto:[email protected]>> Subject: Re: Review Request 1953: cpu: accurately count idle cycles for simple cpu I should probably note that I don't actually know how to update the stats, and obviously this patch changes them. 2013/8/7 Andreas Hansson <[email protected]<mailto:[email protected]>> This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1953/ Ship it! Ship It! - Andreas Hansson On August 7th, 2013, 8:41 p.m. UTC, Lena Olson wrote: Review request for Default. By Lena Olson. Updated Aug. 7, 2013, 8:41 p.m. Repository: gem5 Description Changeset 9811:d0db3e1dab40 --------------------------- cpu: accurately count idle cycles for simple cpu Added a couple missing updates to the notIdleFraction stat. Without these, it sometimes gives a (not) idle fraction that is greater than 1 or less than 0. Diffs * src/cpu/ozone/cpu_impl.hh (e895db06e69f) * src/cpu/simple/atomic.cc (e895db06e69f) * src/cpu/simple/timing.cc (e895db06e69f) View Diff<http://reviews.gem5.org/r/1953/diff/> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
