----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1981/#review4620 -----------------------------------------------------------
src/cpu/reg_class.hh <http://reviews.gem5.org/r/1981/#comment4358> clang static analysis will complain on this last comma src/cpu/reg_class.hh <http://reviews.gem5.org/r/1981/#comment4361> Worth putting in a doxy file? src/cpu/reg_class.hh <http://reviews.gem5.org/r/1981/#comment4360> regIdxToClass? src/cpu/reg_class.hh <http://reviews.gem5.org/r/1981/#comment4359> NULL please, once again, the static analysis will flag it src/cpu/reg_class.cc <http://reviews.gem5.org/r/1981/#comment4362> the trailing semicolon should not be there...I think Some very minor things. For the rest it looks sensible to me. - Andreas Hansson On Aug. 22, 2013, 12:37 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1981/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:37 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9844:7983be7501e7 > --------------------------- > cpu: clean up architectural register classification > > Move from a poorly documented scheme where the mapping > of unified architectural register indices to register > classes is hardcoded all over to one where there's an > enum for the register classes and a function that > encapsulates the mapping. > > > Diffs > ----- > > src/arch/arm/insts/misc.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/arm/insts/static_inst.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/power/insts/static_inst.cc > 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/arch/x86/insts/static_inst.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/SConscript 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/checker/cpu_impl.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/inorder/cpu.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/inorder/cpu.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/inorder/inorder_dyn_inst.cc > 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/dyn_inst.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/rename_impl.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/reg_class.hh PRE-CREATION > src/cpu/reg_class.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/1981/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
