----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1983/#review4622 -----------------------------------------------------------
Ship it! LGTM src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4367> @return? src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4363> const src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4364> const src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4365> const src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4366> const src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4369> 0 <=? Can it be negative? src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4368> const src/cpu/o3/regfile.hh <http://reviews.gem5.org/r/1983/#comment4370> Is there a good reason these are not std::vectors? No need to change...just asking. - Andreas Hansson On Aug. 22, 2013, 12:38 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1983/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9846:816e0d9e97a0 > --------------------------- > cpu/o3: clean up physical register file > > No need for PhysRegFile to be a template class, or > have a pointer back to the CPU. Also made some methods > for checking the physical register type (int vs. float) > based on the phys reg index, which will come in handy later. > > > Diffs > ----- > > src/cpu/o3/cpu.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/cpu_policy.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/regfile.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > > Diff: http://reviews.gem5.org/r/1983/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
