----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1984/#review4623 -----------------------------------------------------------
src/cpu/o3/scoreboard.hh <http://reviews.gem5.org/r/1984/#comment4375> How did we ever get away without it? src/cpu/o3/scoreboard.hh <http://reviews.gem5.org/r/1984/#comment4371> unsigned? src/cpu/o3/scoreboard.hh <http://reviews.gem5.org/r/1984/#comment4372> unsigned? src/cpu/o3/scoreboard.hh <http://reviews.gem5.org/r/1984/#comment4373> const src/cpu/o3/scoreboard.hh <http://reviews.gem5.org/r/1984/#comment4374> const src/cpu/o3/scoreboard.cc <http://reviews.gem5.org/r/1984/#comment4376> Perhaps a bit orthogonal, but should this not be parent.name() + ".scoreboard", where it seems the parent name has to be passed in the constructor. - Andreas Hansson On Aug. 22, 2013, 12:39 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1984/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9847:ed9b78651341 > --------------------------- > cpu/o3: clean up scoreboard object > > It had a bunch of fields (and associated constructor > parameters) thet it didn't really use, and the array > initialization was needlessly verbose. > > Also just hardwired the getReg() method to aleays > return true for misc regs, rather than having an array > of bits that we always kept marked as ready. > > > Diffs > ----- > > src/cpu/o3/cpu.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/rename_impl.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/scoreboard.hh 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > src/cpu/o3/scoreboard.cc 1ddfb0679c7569fb56382ac2187d6de038fd6f28 > > Diff: http://reviews.gem5.org/r/1984/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
