> On Oct. 3, 2013, 3:34 p.m., Steve Reinhardt wrote: > > src/arch/generic/mmapped_ipr.hh, line 65 > > <http://reviews.gem5.org/r/2032/diff/1/?file=37826#file37826line65> > > > > Do we still need the mask & shift? Seems like with the ASI-based > > approach we could simplify things and just stick the class in the address > > w/o shifting.
We still want the upper 16 bits to specify the class of the generic IPR. However, since we use /all/ of the high bits now, shifting would suffice. I'll remove the mask before I push anything. Do you want to run the Solaris test case before I push the patch? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2032/#review4761 ----------------------------------------------------------- On Oct. 3, 2013, 3:21 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2032/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 3:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9905:2f0374a09fc5 > --------------------------- > arch: Use ASI 0xFF instead of bit 63 to for generic IPRs > > Using address bit 63 to identify generic IPRs caused problems on > SPARC, where IPRs are heavily used. This changeset redefines how > generic IPRs are identified. Instead of using bit 63, we now use the > ASI field in a request. We reserve ASI 0xFF for internal gem5 use. ASI > 0xFF is implementation defined on SPARC, which means that we can > safely use it for generic IPRs. No other architecture is currently > using the ASI field. > > > Diffs > ----- > > src/arch/generic/mmapped_ipr.hh e672a39fd426 > src/arch/sparc/asi.hh e672a39fd426 > src/arch/x86/tlb.cc e672a39fd426 > > Diff: http://reviews.gem5.org/r/2032/diff/ > > > Testing > ------- > > m5ops using the IPR interface works on x86 in kvm. ARM, SPARC, and x86 > targets compile. Can't run the affected (80.solaris-boot) test case due to > missing binaries. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
