An example of concise stats is the current format of the generated slicc stats in the ruby.stats file. My primary concern is with the generated state transition stats when many controllers of the same type exist. With the ruby.stats format, all the individual controller counts would be on the same line. With the stats.txt format, those counts are spread across 16 separate lines throughout the file. I don't how anyone could consider that format concise.
I don't think I'm asking for a lot here. I just want the generated state transition stats to maintain a similar format. The stats.txt file already supports a condensed histogram format. Can we do the same for the controller stats? Brad -----Original Message----- From: Nilay Vaish [mailto:[email protected]] Sent: Monday, December 09, 2013 12:07 PM To: Beckmann, Brad Cc: Default Subject: Re: Review Request 2112: stats: updates to changes to ruby On Sat, 7 Dec 2013, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2112/#review4827 > ----------------------------------------------------------- > > > The extreme verbosity of the ruby output concerns me greatly. While > the stats.txt file format is very easy to parse, it is extremely > difficult to read. The generated statistics from ruby controllers are > immensely valuable for debugging performance problems and they are > read often by humans. I do not want to delete the ruby.stats file > until the stats.txt file can provide ruby generated statistics in a similar > concise format. > I strongly argue against this patch begin checked in until we can fix > the stats.txt format. > > Sorry to be so negative on this patch, but I feel pretty strongly about this. > I am open to changes. It would be good if you can provide examples. In my opinion, readability not only a function of what you are reading but also a function of what you are habitual of reading. With time, the current format will also start appearing to be concise. -- Nilay _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
