Nilay, Can you please wait a few more days? I likely won't have a chance to look at this until next week.
Brad -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Nilay Vaish Sent: Thursday, December 19, 2013 6:16 PM To: gem5 Developer List ([email protected]) Subject: Re: [gem5-dev] Review Request 2112: stats: updates to changes to ruby Are there any other comments / questions / suggestions about the patch on doing away with ruby.stats? -- Nilay On Tue, 17 Dec 2013, Nilay Vaish wrote: > Brad, take a look at > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/stats.txt. > > -- > Nilay > > > On Mon, 16 Dec 2013, Beckmann, Brad wrote: > >> Hi Nilay, >> >> Unless you've modified the stats infrastructure to print out counts >> on the same line, when you run with two CPU cores, you will see >> separate lines in stats.txt for the stats of L1 cache controller 0 and L1 >> cache controller 1. >> In ruby.stats, these counts will appear as a list on the same line. >> >> For example see the "system.ruby.l1_cntrl0.I.Load" line in file: >> tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_d >> irectory/stats.txt >> >> Brad >> >> >> >> -----Original Message----- >> From: Nilay Vaish [mailto:[email protected]] >> Sent: Monday, December 16, 2013 11:53 AM >> To: Beckmann, Brad >> Cc: Default >> Subject: RE: Review Request 2112: stats: updates to changes to ruby >> >> On Thu, 12 Dec 2013, Beckmann, Brad wrote: >> >>> An example of concise stats is the current format of the generated >>> slicc stats in the ruby.stats file. My primary concern is with the >>> generated state transition stats when many controllers of the same >>> type exist. >>> With the ruby.stats format, all the individual controller counts >>> would be on the same line. With the stats.txt format, those counts >>> are spread across 16 separate lines throughout the file. I don't how >>> anyone could consider that format concise. >> >> Which controller count are you talking about? If originally >> ruby.stats had the counts on the same line, unless I made a mistake >> somewhere, I would have written code so as to print those counts on the same >> line. >> >>> >>> I don't think I'm asking for a lot here. I just want the generated >>> state transition stats to maintain a similar format. The stats.txt >>> file already supports a condensed histogram format. Can we do the >>> same for the controller stats? >>> >> >> >> >> >> -- >> Nilay >> >> >> >> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
