----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2118/#review4829 -----------------------------------------------------------
>From my side, mostly just minor requested changes below. There are a couple >other things that would be nice to change (like my use of regexes, some of >which make me cringe realizing I once wrote them :P), but it's probably not >necessary to address them at this time. The only big request that I have here is that it would be nice to have some indication about whether/how the McPAT output data has been validated. It's been a long time since I've validated any data, and it would be hard for me to check the McPAT changes since then to see how the outputs may have changed. Can you add some notes on this to the commit message? ext/mcpat/regression/regression.py <http://reviews.gem5.org/r/2118/#comment4517> Minor: Can you add a little more detail here? In particular: "This tester can compile and runs McPAT on the input contained in the specified directory, and then compares the output to that of a prior run in order to ensure that specific power and area calculations do not change." ext/mcpat/regression/regression.py <http://reviews.gem5.org/r/2118/#comment4515> Minor: Can you please use my current email address ([email protected]) in each of these files? ext/mcpat/regression/regression.py <http://reviews.gem5.org/r/2118/#comment4516> Minor: Should this comment actually indicate that this is where we run McPAT on the input? ext/mcpat/regression/test-0/power_region0.xml <http://reviews.gem5.org/r/2118/#comment4514> Minor: Can you please tweak these files to use consistent tabs or spaces, and hierarchical indentation to make them easier to read? - Joel Hestness On Dec. 11, 2013, 10:48 p.m., Yasuko Eckert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2118/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 10:48 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9998:eb810c1d4ff8 > --------------------------- > ext: Add a McPAT regression tester > Add a regression tester to McPAT. Joel Hestness wrote these tests and Yasuko > Eckert modified them to reflect the new McPAT interface. > > > Diffs > ----- > > ext/mcpat/regression/verify_output.py PRE-CREATION > ext/mcpat/regression/test-8/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-8/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-7/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-7/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-6/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-6/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-5/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-5/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-4/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-4/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-3/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-3/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-2/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-2/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-1/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-1/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-0/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-0/power_region0.xml PRE-CREATION > ext/mcpat/regression/regression.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2118/diff/ > > > Testing > ------- > > > Thanks, > > Yasuko Eckert > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
