----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2118/#review4843 -----------------------------------------------------------
Ship it! Thanks for the changes! Looks good to me. - Joel Hestness On Dec. 16, 2013, 9:23 p.m., Yasuko Eckert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2118/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 9:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9998:c9b60f86d969 > --------------------------- > ext: Add a McPAT regression tester > Add a regression tester to McPAT. Joel Hestness wrote these tests and Yasuko > Eckert modified them to reflect the new McPAT interface and other changes > the previous patch #2117 made. > The McPAT output data have been correlated to an AMD CPU core model, which > includes an out-of-order core and L1 caches. However, some of the changes > made during the correlation effort have AMD proprietary information and hence, > are not included in this patch or the previous one #2117. > > > Diffs > ----- > > ext/mcpat/regression/verify_output.py PRE-CREATION > ext/mcpat/regression/test-8/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-8/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-7/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-7/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-6/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-6/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-5/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-5/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-4/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-4/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-3/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-3/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-2/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-2/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-1/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-1/power_region0.xml PRE-CREATION > ext/mcpat/regression/test-0/region0.out.bak PRE-CREATION > ext/mcpat/regression/test-0/power_region0.xml PRE-CREATION > ext/mcpat/regression/regression.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2118/diff/ > > > Testing > ------- > > > Thanks, > > Yasuko Eckert > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
