----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2039/#review4889 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Oct. 10, 2013, 7:49 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2039/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 7:49 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9921:a05240033e7e > --------------------------- > ruby: Simplify RubyPort flow control and routing > > This patch simplfies the retry logic in the RubyPort, avoiding > redundant attributes, and enforcing more stringent checks on the > interactions with the normal ports. The patch also simplifies the > routing done by the RubyPort, using the port identifiers instead of a > heavy-weight sender state. > > The patch also fixes a bug in the sending of responses from PIO > ports. Previously these responses bypassed the queue in the queued > port, and ignored the return value, potentially leading to response > packets being lost. > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.cc 0679c3554ba3 > src/mem/ruby/system/RubyPort.hh 0679c3554ba3 > src/mem/qport.hh 0679c3554ba3 > src/mem/ruby/system/Sequencer.cc 0679c3554ba3 > > Diff: http://reviews.gem5.org/r/2039/diff/ > > > Testing > ------- > > All regressions pass > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
