----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2220/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- ruby: recorder: Fix (de-)serializing with different cache block-sizes Upon aggregating records, serialize the system's cache-block size (add to beginning of byte stream), as the cache-block size can be different when restoring from a checkpoint. This way, we can correctly read all records when restoring from a checkpoints, even if the cache-block size is different. Note, that it is only possible to restore from a checkpoint if the desired cache-block size is smaller or equal to the cache-block size when the checkpoint was taken; we can split one larger request into multiple small ones, but it is not reliable to do the opposite. This patch breaks existing ruby checkpoints. It is possible to fix them by modifying system.ruby.cache.gz and prepend the cache-block size the checkpoints were taken with. Diffs ----- src/mem/ruby/recorder/CacheRecorder.hh 52c552138ba1 src/mem/ruby/recorder/CacheRecorder.cc 52c552138ba1 Diff: http://reviews.gem5.org/r/2220/diff/ Testing ------- Created a Ruby checkpoint with the default config. Restore from checkpoint with default config (64 byte block-size) and varying block-sizes (32, 16, 8). Thanks, Marco Elver _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
