----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5182 -----------------------------------------------------------
src/dev/Ethernet.py <http://reviews.gem5.org/r/2305/#comment4695> port speed? src/dev/Ethernet.py <http://reviews.gem5.org/r/2305/#comment4696> Seem to be a duplicate src/dev/SConscript <http://reviews.gem5.org/r/2305/#comment4697> has it gotten to a point where it's worth adding a src/dev/ether directory? src/dev/etherlink.hh <http://reviews.gem5.org/r/2305/#comment4698> whitespace src/dev/etherlink.cc <http://reviews.gem5.org/r/2305/#comment4699> safe_cast? Somehow this seems a bit dubious src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4700> dev src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4701> Should it really be ticked? src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4702> const src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4703> const src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4704> const src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4705> is this not just the length of the vector? src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4706> should this be public? src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4707> const? src/dev/etherswitch.hh <http://reviews.gem5.org/r/2305/#comment4708> const? src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4709> if you want: for (auto i: interfaces) delete i; src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4710> fatal? even fatal_if src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4711> why + 10? src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4712> why 1000? Should this whole thing not be event driven rather than ticked? src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4713> perhaps i just don't understand the rules here, should this not return true when successfully sending something? src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4714> auto and range-based for is your friend :-) src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4715> auto src/dev/etherswitch.cc <http://reviews.gem5.org/r/2305/#comment4716> seems like a bug to me... This looks like a great start. There are plenty places where auto and range-based for loops will make the code a lot easier to read. In general I am a bit surprised to see the ticked interface being used, as the switch clearly just does what ever it is asked to do, and should be able to rely on events scheduled when something arrives. - Andreas Hansson On June 27, 2014, 6:24 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 6:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10243:d135e653e6eb > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > > > Diffs > ----- > > src/dev/Ethernet.py cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/SConscript cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherint.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherlink.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherlink.cc cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2305/diff/ > > > Testing > ------- > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
