> On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/Ethernet.py, line 60 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40129#file40129line60> > > > > port speed?
this is the fabric links' speed. i changed the name to be more descriptive. > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 54 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40135#file40135line54> > > > > if you want: > > > > for (auto i: interfaces) > > delete i; Fixed throughout. Need to remind myself to use c++11 for things like this... > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 100 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40134#file40134line100> > > > > const? can't be made const, calls methods that may change certain fields. > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 99 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40134#file40134line99> > > > > const? can't be made const, calls methods that may change certain fields. > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.hh, line 82 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40134#file40134line82> > > > > is this not just the length of the vector? this keeps track of how many links are being broadcast to, the broadcast peers keeps track of which peers still need to be broadcast to, in case the link is busy. > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/etherlink.cc, line 254 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40133#file40133line254> > > > > safe_cast? > > > > Somehow this seems a bit dubious Because this code is only used with EtherLink objects this should be safe. I could make it a dynamic cast if you'd like. > On July 10, 2014, 12:48 p.m., Andreas Hansson wrote: > > src/dev/SConscript, line 58 > > <http://reviews.gem5.org/r/2305/diff/1/?file=40130#file40130line58> > > > > has it gotten to a point where it's worth adding a src/dev/ether > > directory? That is probably a good idea. I don't know what others think. On July 10, 2014, 12:48 p.m., Anthony Gutierrez wrote: > > This looks like a great start. There are plenty places where auto and > > range-based for loops will make the code a lot easier to read. > > > > In general I am a bit surprised to see the ticked interface being used, as > > the switch clearly just does what ever it is asked to do, and should be > > able to rely on events scheduled when something arrives. Sorry the ticking was just for temporary testing purposes. I shouldn't have submitted it that way. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5182 ----------------------------------------------------------- On June 27, 2014, 6:24 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2305/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 6:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10243:d135e653e6eb > --------------------------- > dev: add an ethernet switch model > > this patch adds a very simple ethernet switch model. the basic design > behind the switch is to modularize the interface, fabric, and overall > switch model as much as possible. The switch model: > > 1) buffers incoming/outgoing packets in the ports > 2) utilizes Links from EtherLink as the point-to-point connections > in the switch fabric > 3) uses a simple least-recently-granted arbitration policy to forward packets, > and doesn't provide any support for things like flow control. it also does > not provide any features outside the link layer, which some switches may > support e.g., ARP, filtering, etc. > > > Diffs > ----- > > src/dev/Ethernet.py cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/SConscript cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherint.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherlink.hh cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherlink.cc cb4e86c177672fde6be7a409793c944e36353fc0 > src/dev/etherswitch.hh PRE-CREATION > src/dev/etherswitch.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2305/diff/ > > > Testing > ------- > > Successfully ran 3 systems with 1 memcached server and 2 memcached clients > simultaneously issuing requests. > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
