> On Aug. 14, 2014, 9:22 a.m., Andreas Sandberg wrote: > > src/arch/x86/pagetable.hh, line 169 > > <http://reviews.gem5.org/r/2319/diff/1/?file=40442#file40442line169> > > > > I'd prefer to see this refactored so that the X86 architectural page > > table inherits from the multi-level page table instead. (See RB2312.) I > > find it very hard to believe that there is any performance improvement by > > using templates here.
Currently, trying this. I have issues with the header files and cyclic dependencies. We'll see if I can get a version with inheritance. - Alexandru ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2319/#review5246 ----------------------------------------------------------- On July 28, 2014, 10:30 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2319/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 10:30 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10265:c300dff4dd76 > --------------------------- > Mem: adding architectural page table support for SE mode > This patch enables the use of page tables that are stored in system memory > and respect x86 specification, in SE mode. It defines an architectural > page table for x86 as a MultiLevelPageTable class and puts a placeholder > class for other ISAs page tables, giving the possibility for future > implementation. > > > Diffs > ----- > > src/arch/alpha/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/arm/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/mips/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/power/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/sparc/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/x86/pagetable.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/x86/pagetable_walker.cc c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/x86/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/arch/x86/system.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/mem/SConscript c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/sim/Process.py c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/sim/process.hh c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > src/sim/process.cc c00b5ba43967e7e48a28b7ddc48c9f4afaf2ab76 > > Diff: http://reviews.gem5.org/r/2319/diff/ > > > Testing > ------- > > Regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
