> On Aug. 24, 2014, 2:08 p.m., Andreas Hansson wrote: > > src/mem/ruby/common/TypeDefines.hh, line 33 > > <http://reviews.gem5.org/r/2350/diff/1/?file=40783#file40783line33> > > > > It would be nice to prune these as well and rely in the established > > uint64_t int64_t etc.
I'll drop these typedefs in separate patch. On Aug. 24, 2014, 2:08 p.m., Nilay Vaish wrote: > > In STL all index types tends to be size_t. Is there a reason for not using > > that here? I don't think there is any particular reason. I myself typically use int / int64_t depending on how large I expect the index to be. I think using int64 is fine for these pieces of the code. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2350/#review5297 ----------------------------------------------------------- On Aug. 16, 2014, 1:32 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2350/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 1:32 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10294:b79de412799b > --------------------------- > ruby: remove typedef of Index as int64 > The Index type defined as typedef int64 does not really provide any help > since in most places we use primitive types instead of Index. Also, the name > Index is very generic that it does not merit being used as a typename. > > > Diffs > ----- > > src/mem/ruby/common/Address.hh 79fde1c67ed8 > src/mem/ruby/common/Address.cc 79fde1c67ed8 > src/mem/ruby/common/TypeDefines.hh 79fde1c67ed8 > src/mem/ruby/structures/AbstractReplacementPolicy.hh PRE-CREATION > src/mem/ruby/structures/BankedArray.hh PRE-CREATION > src/mem/ruby/structures/BankedArray.cc PRE-CREATION > src/mem/ruby/structures/CacheMemory.hh PRE-CREATION > src/mem/ruby/structures/CacheMemory.cc PRE-CREATION > src/mem/ruby/structures/DirectoryMemory.cc PRE-CREATION > src/mem/ruby/structures/LRUPolicy.hh PRE-CREATION > src/mem/ruby/structures/PseudoLRUPolicy.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/2350/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
