----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2372/#review5321 -----------------------------------------------------------
I looked into this tool a couple of months ago. At the time, I encountered some issues relating to indentation (IIRC, the way we indent case labels by 2 spaces wasn't supported). My conclusion at the time was that it wasn't possible to configure clang-format to adhere to the gem5 style. Has this changed? If not, I'd suggest that we don't commit this for now and wait while clang-format matures. .clang-format <http://reviews.gem5.org/r/2372/#comment4837> Shouldn't this be -2? .clang-format <http://reviews.gem5.org/r/2372/#comment4838> I used 78 here. .clang-format <http://reviews.gem5.org/r/2372/#comment4840> Has this changed name? The clang documentation lists DerivePointerAlignment, but not DerivePointerBinding. .clang-format <http://reviews.gem5.org/r/2372/#comment4839> Shouldn't this be 'Linux'? That'd add a newline after function/namespace/class definitions. .clang-format <http://reviews.gem5.org/r/2372/#comment4841> ?? - Andreas Sandberg On Sept. 1, 2014, 7:05 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2372/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 7:05 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10318:a79d63495fed > --------------------------- > style: add .clang-format file > > The format specified in this file is used by clang-format to fix > the formatting of a given file. > > > Diffs > ----- > > .clang-format PRE-CREATION > > Diff: http://reviews.gem5.org/r/2372/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
