----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2411/#review5354 -----------------------------------------------------------
src/sim/syscall_emul_buf.hh <http://reviews.gem5.org/r/2411/#comment4852> Are there classes inheriting from this? If so, gcc 4.7 and beyond will be unhappy about removing the virtual keyword for the destructor. - Andreas Hansson On Sept. 23, 2014, 7:47 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2411/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 7:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10414:d0d259e12596 > --------------------------- > syscall emulation: devirtualize BaseBufferArg methods > > Not clear why they were marked virtual to begin with, > but that doesn't appear to be necessary. > > > Diffs > ----- > > src/sim/syscall_emul_buf.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/2411/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
