> On Sept. 24, 2014, 4:09 a.m., Andreas Hansson wrote: > > src/sim/syscall_emul_buf.hh, line 73 > > <http://reviews.gem5.org/r/2411/diff/1/?file=41616#file41616line73> > > > > Are there classes inheriting from this? If so, gcc 4.7 and beyond will > > be unhappy about removing the virtual keyword for the destructor.
There are two classes that derive from this (BufferArg and TypedBufferArg, both below this in the same file). However, none of the derived classes provides a destructor, so there's no need for a virtual destructor. I've been compiling with gcc 4.8 and have not seen a warning, I believe because the warning only applies if the base class defines other virtual functions: https://gcc.gnu.org/wiki/VerboseDiagnostics#delete-non-virtual-dtor I actually hesitated a bit before getting rid of this, as you would need to put it back if you did start using these classes polymorphically, so I'm glad to know that gcc will provide a warning in that case. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2411/#review5354 ----------------------------------------------------------- On Sept. 23, 2014, 12:47 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2411/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 12:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10414:d0d259e12596 > --------------------------- > syscall emulation: devirtualize BaseBufferArg methods > > Not clear why they were marked virtual to begin with, > but that doesn't appear to be necessary. > > > Diffs > ----- > > src/sim/syscall_emul_buf.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/2411/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
