----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2208/#review5365 -----------------------------------------------------------
Ship it! src/mem/ruby/system/Sequencer.py <http://reviews.gem5.org/r/2208/#comment4863> copy paste Looks good - Andreas Hansson On Sept. 25, 2014, 4:39 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2208/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 4:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10416:bc430ee79714 > --------------------------- > ruby: dma sequencer: remove RubyPort as parent class > As of now DMASequencer inherits from the RubyPort class. But the code in > RubyPort class is heavily tailored for the CPU Sequencer. There are parts of > the code that are not required at all for the DMA sequencer. Moreover, the > next patch uses the dma sequencer for carrying out memory accesses for all the > io devices. Hence, it is better to have a leaner dma sequencer. > > > Diffs > ----- > > src/mem/ruby/system/DMASequencer.hh d96740732a61 > src/mem/ruby/system/DMASequencer.cc d96740732a61 > src/mem/ruby/system/Sequencer.py d96740732a61 > > Diff: http://reviews.gem5.org/r/2208/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
