----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2447/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10443:8a6c6e7d4ea5 --------------------------- arch: Use shared_ptr for all Faults This patch takes quite a large step in transitioning from the ad-hoc RefCountingPtr to the c++11 shared_ptr by adopting its use for all Faults. There are no changes in behaviour, and the code modifications are mostly just replacing "new" with "make_shared". Diffs ----- src/arch/alpha/ev5.cc 28b31101d9e6 src/arch/alpha/faults.hh 28b31101d9e6 src/arch/alpha/interrupts.hh 28b31101d9e6 src/arch/alpha/isa/decoder.isa 28b31101d9e6 src/arch/alpha/isa/fp.isa 28b31101d9e6 src/arch/alpha/isa/opcdec.isa 28b31101d9e6 src/arch/alpha/isa/unimp.isa 28b31101d9e6 src/arch/alpha/isa/unknown.isa 28b31101d9e6 src/arch/alpha/tlb.cc 28b31101d9e6 src/arch/arm/insts/static_inst.hh 28b31101d9e6 src/arch/arm/interrupts.hh 28b31101d9e6 src/arch/arm/isa/formats/breakpoint.isa 28b31101d9e6 src/arch/arm/isa/formats/unimp.isa 28b31101d9e6 src/arch/arm/isa/insts/branch.isa 28b31101d9e6 src/arch/arm/isa/insts/branch64.isa 28b31101d9e6 src/arch/arm/isa/insts/data64.isa 28b31101d9e6 src/arch/arm/isa/insts/fp.isa 28b31101d9e6 src/arch/arm/isa/insts/macromem.isa 28b31101d9e6 src/arch/arm/isa/insts/misc.isa 28b31101d9e6 src/arch/arm/isa/insts/misc64.isa 28b31101d9e6 src/arch/arm/isa/insts/neon.isa 28b31101d9e6 src/arch/arm/isa/insts/neon64.isa 28b31101d9e6 src/arch/arm/isa/insts/neon64_mem.isa 28b31101d9e6 src/arch/arm/isa/insts/swap.isa 28b31101d9e6 src/arch/arm/isa/templates/mem64.isa 28b31101d9e6 src/arch/arm/isa/templates/neon.isa 28b31101d9e6 src/arch/arm/isa/templates/vfp.isa 28b31101d9e6 src/arch/arm/table_walker.cc 28b31101d9e6 src/arch/arm/tlb.cc 28b31101d9e6 src/arch/arm/utility.cc 28b31101d9e6 src/arch/mips/interrupts.cc 28b31101d9e6 src/arch/mips/isa/decoder.isa 28b31101d9e6 src/arch/mips/isa/formats/control.isa 28b31101d9e6 src/arch/mips/isa/formats/dsp.isa 28b31101d9e6 src/arch/mips/isa/formats/fp.isa 28b31101d9e6 src/arch/mips/isa/formats/int.isa 28b31101d9e6 src/arch/mips/isa/formats/mt.isa 28b31101d9e6 src/arch/mips/isa/formats/trap.isa 28b31101d9e6 src/arch/mips/isa/formats/unimp.isa 28b31101d9e6 src/arch/mips/isa/formats/unknown.isa 28b31101d9e6 src/arch/mips/mt.hh 28b31101d9e6 src/arch/power/isa/formats/unimp.isa 28b31101d9e6 src/arch/power/isa/formats/unknown.isa 28b31101d9e6 src/arch/power/tlb.cc 28b31101d9e6 src/arch/sparc/interrupts.hh 28b31101d9e6 src/arch/sparc/isa/base.isa 28b31101d9e6 src/arch/sparc/isa/decoder.isa 28b31101d9e6 src/arch/sparc/isa/formats/mem/util.isa 28b31101d9e6 src/arch/sparc/isa/formats/priv.isa 28b31101d9e6 src/arch/sparc/isa/formats/trap.isa 28b31101d9e6 src/arch/sparc/isa/formats/unknown.isa 28b31101d9e6 src/arch/sparc/tlb.cc 28b31101d9e6 src/arch/sparc/utility.cc 28b31101d9e6 src/arch/x86/interrupts.cc 28b31101d9e6 src/arch/x86/isa/formats/string.isa 28b31101d9e6 src/arch/x86/isa/formats/unknown.isa 28b31101d9e6 src/arch/x86/isa/insts/general_purpose/compare_and_test/bounds.py 28b31101d9e6 src/arch/x86/isa/insts/general_purpose/control_transfer/interrupts_and_exceptions.py 28b31101d9e6 src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py 28b31101d9e6 src/arch/x86/isa/insts/system/undefined_operation.py 28b31101d9e6 src/arch/x86/isa/insts/x87/arithmetic/addition.py 28b31101d9e6 src/arch/x86/isa/insts/x87/arithmetic/subtraction.py 28b31101d9e6 src/arch/x86/isa/insts/x87/data_transfer_and_conversion/exchange.py 28b31101d9e6 src/arch/x86/isa/microops/debug.isa 28b31101d9e6 src/arch/x86/isa/microops/regop.isa 28b31101d9e6 src/arch/x86/pagetable_walker.cc 28b31101d9e6 src/arch/x86/tlb.cc 28b31101d9e6 src/base/types.hh 28b31101d9e6 src/cpu/inorder/inorder_dyn_inst.cc 28b31101d9e6 src/cpu/o3/dyn_inst_impl.hh 28b31101d9e6 src/cpu/o3/lsq_unit.hh 28b31101d9e6 src/cpu/o3/lsq_unit_impl.hh 28b31101d9e6 src/sim/fault_fwd.hh 28b31101d9e6 src/sim/faults.hh 28b31101d9e6 Diff: http://reviews.gem5.org/r/2447/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
