----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2448/#review5399 -----------------------------------------------------------
Ship it! src/python/m5/params.py <http://reviews.gem5.org/r/2448/#comment4894> Should be a space after the comma here, though I see now that this is just a copy of the same style error that occurs with several existing params. - Steve Reinhardt On Sept. 29, 2014, 3:40 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2448/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 3:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10444:dec5e0f271c5 > --------------------------- > config: Add Current as a parameter type > > This patch adds the Python parameter type Current, which is used for > the DRAM power modelling (to start with). With this addition we avoid > implicit unit assumptions. > > > Diffs > ----- > > src/python/m5/params.py 28b31101d9e6 > src/python/m5/util/convert.py 28b31101d9e6 > > Diff: http://reviews.gem5.org/r/2448/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
