----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2464/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10478:8bc1fcad2a8f --------------------------- misc: Use gmtime for conversion to UTC to avoid getenv/setenv This patch changes how we turn time into UTC. Previously we manipulated the TZ environment variable, but this has issues as the strings that are manipulated could be tainted (see e.g. CERT ENV34-C). Now we simply rely on the built-in gmtime function and avoid touching getenv/setenv all together. Diffs ----- src/base/time.cc 3a87241adfb8 src/dev/sparc/dtod.cc 3a87241adfb8 Diff: http://reviews.gem5.org/r/2464/diff/ Testing ------- All regressions pass, in UK as well as US :-) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
