----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2464/#review5415 -----------------------------------------------------------
I take it there are no objections to these minor fixes and will go ahead and push before the end of the day. - Andreas Hansson On Oct. 14, 2014, 7:55 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2464/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 7:55 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10478:8bc1fcad2a8f > --------------------------- > misc: Use gmtime for conversion to UTC to avoid getenv/setenv > > This patch changes how we turn time into UTC. Previously we > manipulated the TZ environment variable, but this has issues as the > strings that are manipulated could be tainted (see e.g. CERT > ENV34-C). Now we simply rely on the built-in gmtime function and avoid > touching getenv/setenv all together. > > > Diffs > ----- > > src/base/time.cc 3a87241adfb8 > src/dev/sparc/dtod.cc 3a87241adfb8 > > Diff: http://reviews.gem5.org/r/2464/diff/ > > > Testing > ------- > > All regressions pass, in UK as well as US :-) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
