----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2465/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10481:dd7fc6e5eaa0 --------------------------- x86: Fixes to avoid LTO warnings This patch fixes a few minor issues that caused link-time warnings when using LTO, mainly for x86. The most important change is how the syscall array is created. Previously gcc and clang would complain that the declaration and definition types did not match. The organisation is now changed to match how it is done for ARM, moving the code that was previously in syscalls.cc into process.cc, and having a class variable pointing to the static array. With these changes, there are no longer any warnings using gcc 4.6.3 with LTO. Diffs ----- src/arch/x86/SConscript 3a87241adfb8 src/arch/x86/linux/process.hh 3a87241adfb8 src/arch/x86/linux/process.cc 3a87241adfb8 src/arch/x86/linux/syscalls.cc 3a87241adfb8 src/sim/system.hh 3a87241adfb8 src/sim/system.cc 3a87241adfb8 Diff: http://reviews.gem5.org/r/2465/diff/ Testing ------- Tried with clang 3.4, 3.5 and gcc 4.6 and 4.9 and this fixes the warnings Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
