----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2468/#review5431 -----------------------------------------------------------
thanks for the patch. it looks good, but I'm not sure if the ruby change it supposed to be in there. otherwise I think it's good to go. src/mem/ruby/system/RubyMemoryControl.cc <http://reviews.gem5.org/r/2468/#comment4911> is this change supposed to be in here? - Ali Saidi On Oct. 26, 2014, 5:16 p.m., Alberto Javier Naranjo Carmona wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2468/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2014, 5:16 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch solves some bugs that occured when using the option > --repeat-switch, in particular when switching from O3 to timing model > (deadlocks while draining and assert(!memReq) in drainSanityCheck()). See the > following thread for more info > http://www.mail-archive.com/gem5-users%40gem5.org/msg10631.html > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh PRE-CREATION > src/cpu/o3/lsq_impl.hh PRE-CREATION > src/cpu/o3/lsq_unit.hh PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2468/diff/ > > > Testing > ------- > > All long regression tests passed. tsunami-switcheroo-full passed. > > > Thanks, > > Alberto Javier Naranjo Carmona > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
