----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2494/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10544:b595245892d9 --------------------------- mem: Assume all dynamic packet data is array allocated This patch simplifies how we deal with dynamically allocated data in the packet, always assuming that it is array allocated, and hence should be array deallocated (delete[] as opposed to delete). The only uses of dataDynamic was in the Ruby testers, and these are now changed to use Packet::allocate or dataDynamicArray as appropriate. The ARRAY_DATA flag in the packet is removed accordingly. No defragmentation of the flags is done at this point, leaving a gap in the bit masks. Going forward I would suggest a name change to better reflect the semantics, perhaps: dataStatic -> dataNoFree dataDynamic -> dataToFree Diffs ----- src/cpu/testers/directedtest/InvalidateGenerator.cc 1a9e235cab09 src/cpu/testers/directedtest/SeriesRequestGenerator.cc 1a9e235cab09 src/cpu/testers/rubytest/Check.cc 1a9e235cab09 src/mem/packet.hh 1a9e235cab09 src/mem/ruby/slicc_interface/AbstractController.cc 1a9e235cab09 Diff: http://reviews.gem5.org/r/2494/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
