> On Nov. 29, 2014, 8:52 p.m., Steve Reinhardt wrote: > > Since the static/dynamic distinction also impacts the semantics on copies, > > I think renaming to dataNoFree/dataToFree is overly simplistic. Since > > there's no distinction between array and non-array dynamic data, though, I > > suggest keeping the dataDynamic() name rather than the dataDyanamicArray() > > name (even though the retained semantics matches the latter).
I have dropped the Array bit from the name now. I'll also update the patch description to reflect this change. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2494/#review5571 ----------------------------------------------------------- On Nov. 30, 2014, 9:24 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2494/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 9:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10567:4b6d25498f4b > --------------------------- > mem: Assume all dynamic packet data is array allocated > > This patch simplifies how we deal with dynamically allocated data in > the packet, always assuming that it is array allocated, and hence > should be array deallocated (delete[] as opposed to delete). The only > uses of dataDynamic was in the Ruby testers, and these are now changed > to use Packet::allocate or dataDynamicArray as appropriate. > > The ARRAY_DATA flag in the packet is removed accordingly. No > defragmentation of the flags is done at this point, leaving a gap in > the bit masks. Going forward I would suggest a name change to better > reflect the semantics, perhaps: > > dataStatic -> dataNoFree > > dataDynamic -> dataToFree > > > Diffs > ----- > > src/cpu/minor/lsq.cc dd04eb06ad42 > src/cpu/o3/fetch_impl.hh dd04eb06ad42 > src/cpu/simple/timing.cc dd04eb06ad42 > src/cpu/testers/directedtest/InvalidateGenerator.cc dd04eb06ad42 > src/cpu/testers/directedtest/SeriesRequestGenerator.cc dd04eb06ad42 > src/cpu/testers/memtest/memtest.cc dd04eb06ad42 > src/cpu/testers/networktest/networktest.cc dd04eb06ad42 > src/cpu/testers/rubytest/Check.cc dd04eb06ad42 > src/cpu/testers/traffic_gen/generators.cc dd04eb06ad42 > src/mem/packet.hh dd04eb06ad42 > > Diff: http://reviews.gem5.org/r/2494/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
