----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2313/#review5480 -----------------------------------------------------------
src/arch/x86/pseudo_inst.hh <http://reviews.gem5.org/r/2313/#comment4930> I think this can probably be in the main X86ISA namespace. That would remove the need for a new magic macro up in src/SConscript. src/arch/x86/pseudo_inst.hh <http://reviews.gem5.org/r/2313/#comment4931> These should be camel case, not all lower case. ie. m5Syscall and m5PageFault, depending on what you consider the boundary between words. These should also be called gem5*. src/arch/x86/pseudo_inst.cc <http://reviews.gem5.org/r/2313/#comment4927> Don't put spaces inside the parenthesis. src/arch/x86/pseudo_inst.cc <http://reviews.gem5.org/r/2313/#comment4928> Put spaces around the operator. src/arch/x86/pseudo_inst.cc <http://reviews.gem5.org/r/2313/#comment4929> Remove extra space. util/m5/m5ops.h <http://reviews.gem5.org/r/2313/#comment4932> Why do we need psuedo ops for syscalls when there are actual syscall instructions? The same goes for page faults. I'm not saying I know that we don't, I'm just surprised that that would be necessary. It seems unlikely that a program is going to realize it's about to cause a pagefault and obligingly call a special instruction first. - Gabe Black On Sept. 30, 2014, 4:21 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2313/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 4:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10421:d4162e1b1c56 > --------------------------- > kvm, x86: Adding support for SE mode execution > This patch adds methods in KvmCPU model to handle KVM exits caused by syscall > instructions and page faults. These types of exits will be encountered if > KvmCPU is run in SE mode. > > > Diffs > ----- > > src/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/alpha/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/arm/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/arm/pseudo_inst.hh PRE-CREATION > src/arch/arm/pseudo_inst.cc PRE-CREATION > src/arch/mips/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/power/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/sparc/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/x86/SConscript 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/x86/pseudo_inst.hh PRE-CREATION > src/arch/x86/pseudo_inst.cc PRE-CREATION > src/arch/x86/tlb.cc 28b31101d9e6e5e75d04448451986d6318383f3c > src/arch/x86/utility.cc 28b31101d9e6e5e75d04448451986d6318383f3c > src/cpu/kvm/base.cc 28b31101d9e6e5e75d04448451986d6318383f3c > src/sim/pseudo_inst.cc 28b31101d9e6e5e75d04448451986d6318383f3c > src/sim/system.cc 28b31101d9e6e5e75d04448451986d6318383f3c > util/m5/m5ops.h 28b31101d9e6e5e75d04448451986d6318383f3c > > Diff: http://reviews.gem5.org/r/2313/diff/ > > > Testing > ------- > > Quick regressions passed. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
