----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5544 -----------------------------------------------------------
src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4973> We don't need this nack(). src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4974> Is some code missing here? You did not write anything to the output port. src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4975> Do we need this change? This does not exceed the line length limit. src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4976> Do we need this change? This does not exceed the line length limit. src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4977> Do we need this change? This does not exceed the line length limit. src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4978> A single line seems possible. src/dev/x86/i8042.cc <http://reviews.gem5.org/r/2519/#comment4979> A single line seems possible. - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2519/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10555:595f40e72481 > --------------------------- > x86: i8042: Give the keyboard controller a little TLC. > > This CL fixes a few minor bugs, and fills out the general implementation a bit > so that it can more readily support actually returning keyboard input. > > > Diffs > ----- > > src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c > src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c > > Diff: http://reviews.gem5.org/r/2519/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
