----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2491/ -----------------------------------------------------------
(Updated Nov. 30, 2014, 9:31 a.m.) Review request for Default. Repository: gem5 Description (updated) ------- Changeset 10564:75153948fe34 --------------------------- mem: Add const getters for write packet data This patch takes a first step in tightening up how we use the data pointer in write packets. A const getter is added for the pointer itself (getConstPtr), and a number of member functions are also made const accordingly. In a range of places throughout the memory system the new member is used. The patch also removes the unused isReadWrite function. Diffs (updated) ----- src/cpu/inorder/resources/cache_unit.cc dd04eb06ad42 src/cpu/inorder/resources/fetch_unit.cc dd04eb06ad42 src/cpu/minor/execute.cc dd04eb06ad42 src/cpu/minor/lsq.cc dd04eb06ad42 src/cpu/o3/fetch_impl.hh dd04eb06ad42 src/cpu/simple/atomic.cc dd04eb06ad42 src/cpu/testers/memtest/memtest.cc dd04eb06ad42 src/cpu/testers/rubytest/Check.cc dd04eb06ad42 src/mem/abstract_mem.cc dd04eb06ad42 src/mem/cache/cache.hh dd04eb06ad42 src/mem/cache/cache_impl.hh dd04eb06ad42 src/mem/external_slave.cc dd04eb06ad42 src/mem/packet.hh dd04eb06ad42 src/mem/packet.cc dd04eb06ad42 src/mem/packet_access.hh dd04eb06ad42 src/mem/ruby/common/DataBlock.hh dd04eb06ad42 src/mem/ruby/common/DataBlock.cc dd04eb06ad42 src/mem/ruby/slicc_interface/RubyRequest.cc dd04eb06ad42 src/mem/ruby/slicc_interface/RubySlicc_Util.hh dd04eb06ad42 src/mem/ruby/system/Sequencer.cc dd04eb06ad42 Diff: http://reviews.gem5.org/r/2491/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
