I am fine with the unlinkHelper suggestion, but this makes the new code different from the other syscall implentations. (openFunc, readlinkFunc, etc).
I simply copied what was already there. I will update the diff, and folks can let me know if you want the other functions mapped to a similar architecture... On Thu, Dec 4, 2014 at 3:12 PM, Steve Reinhardt <[email protected]> wrote: > > > On Thu, Dec 4, 2014 at 2:50 PM, Ali Saidi via gem5-dev <[email protected]> > wrote: > >> >> The default parameter for the 5 parameter version could probably be >> removed > > > s/could probably/should definitely/, I would say. > > I believe the 5-parameter version only gets called from either the > 4-parameter version or from unlinkatFunc, so the default value is never > used and only sows confusion. The 5-parameter version could even be > renamed something like unlinkHelper. > > Steve > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
