> On Dec. 4, 2014, 6:59 p.m., Steve Reinhardt wrote:
> > src/base/remote_gdb.hh, line 118
> > <http://reviews.gem5.org/r/2540/diff/1/?file=42812#file42812line118>
> >
> >     I'd be tempted to rename the other Event class rather than have to 
> > disambiguate here, but I understand if you don't want to be that invasive

That seems like a good idea, but I'll do it in a later commit to keep from 
muddying what's going on in this one.


- Gabe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2540/#review5631
-----------------------------------------------------------


On Nov. 25, 2014, 11:47 a.m., Gabe Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2540/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 11:47 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10568:140bd3e1bbc7
> ---------------------------
> sim: Ensure GDB interrupts the simulation at an instruction boundary.
> 
> Use the comInstEventQueue to ensure GDB interrupts the simulation at an
> instruction boundary and not in the middle of a macroop, memory access, etc.
> 
> 
> Diffs
> -----
> 
>   src/base/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a 
>   src/base/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a 
> 
> Diff: http://reviews.gem5.org/r/2540/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gabe Black
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to