> On Dec. 4, 2014, 6:50 p.m., Steve Reinhardt wrote: > > src/base/remote_gdb.cc, line 2 > > <http://reviews.gem5.org/r/2540/diff/1/?file=42813#file42813line2> > > > > date?
Fixed. > On Dec. 4, 2014, 6:50 p.m., Steve Reinhardt wrote: > > src/base/remote_gdb.cc, line 255 > > <http://reviews.gem5.org/r/2540/diff/1/?file=42813#file42813line255> > > > > I could use a comment here reminding me that, despite the names, this > > event is actually scheduled for the next committed instruction and not the > > next tick Yep, that's a good idea. Done. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2540/#review5627 ----------------------------------------------------------- On Nov. 25, 2014, 11:47 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2540/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 11:47 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10568:140bd3e1bbc7 > --------------------------- > sim: Ensure GDB interrupts the simulation at an instruction boundary. > > Use the comInstEventQueue to ensure GDB interrupts the simulation at an > instruction boundary and not in the middle of a macroop, memory access, etc. > > > Diffs > ----- > > src/base/remote_gdb.hh f9fb64a72259a2514080151b5250a04c575d443a > src/base/remote_gdb.cc f9fb64a72259a2514080151b5250a04c575d443a > > Diff: http://reviews.gem5.org/r/2540/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
