Yeah, I'm not sure which way to go. I think broadening the definition of a pseudo instruction makes sense, but there's a reasonable amount of existing usage we'd want to update to keep things from being confusing. You might call the file util_inst? Or if it's in a directory of just instruction definitions maybe plain util. When I first saw nonisa I thought it said noisa, and if I were to see it correctly but not have the context of this conversation it wouldn't be obvious (to me at least) what was in there.
Gabe On Tue, Dec 16, 2014 at 7:18 AM, Andreas Sandberg via gem5-dev < [email protected]> wrote: > > > > > On Dec. 12, 2014, 10:24 p.m., Gabe Black wrote: > > > While it's definitely nice to get these into regular C++ instead of > the ISA language, my concern is that these aren't really pseudo > instructions. They are in the sense that they're instructions that wouldn't > exist outside of the simulator, but there's a well defined pseudo inst > concept they don't really fit in. Maybe put them in a .cc and .hh file with > a different name? > > I see your point. We could rename them to something like "nonisa" since > they aren't a part of the visible ISA. Would that be a good name? Another > option is to just say that everything in gem5 that isn't a proper > ISA-defined instruction is a pseudo instruction and that m5ops are just a > subset of those. > > > - Andreas > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2567/#review5684 > ----------------------------------------------------------- > > > On Dec. 12, 2014, 5:45 p.m., Andreas Hansson wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.gem5.org/r/2567/ > > ----------------------------------------------------------- > > > > (Updated Dec. 12, 2014, 5:45 p.m.) > > > > > > Review request for Default. > > > > > > Repository: gem5 > > > > > > Description > > ------- > > > > Changeset 10612:2bd582d94965 > > --------------------------- > > arm: Merge ISA files with pseudo instructions > > > > This changeset moves the pseudo instructions used to signal unknown > > instructions and unimplemented instructions to the same source files > > as the decoder fault. > > > > > > Diffs > > ----- > > > > src/arch/arm/insts/pseudo.hh PRE-CREATION > > src/arch/arm/insts/pseudo.cc PRE-CREATION > > src/arch/arm/isa/formats/formats.isa 8fc6e7a835d1 > > src/arch/arm/isa/formats/pseudo.isa PRE-CREATION > > src/arch/arm/isa/formats/unimp.isa 8fc6e7a835d1 > > src/arch/arm/isa/formats/unknown.isa 8fc6e7a835d1 > > > > Diff: http://reviews.gem5.org/r/2567/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Andreas Hansson > > > > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
