----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2567/#review5896 -----------------------------------------------------------
Ship it! As I mentioned in the email thread, we're not very consistent in distinguishing "pseudoinstructions" from "m5ops" from whatever other related but distinct categories we have. It would be nice to clean that up, but I don't think this patch makes things any worse, so I don't object. - Steve Reinhardt On Dec. 12, 2014, 9:45 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2567/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 9:45 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10612:2bd582d94965 > --------------------------- > arm: Merge ISA files with pseudo instructions > > This changeset moves the pseudo instructions used to signal unknown > instructions and unimplemented instructions to the same source files > as the decoder fault. > > > Diffs > ----- > > src/arch/arm/insts/pseudo.hh PRE-CREATION > src/arch/arm/insts/pseudo.cc PRE-CREATION > src/arch/arm/isa/formats/formats.isa 8fc6e7a835d1 > src/arch/arm/isa/formats/pseudo.isa PRE-CREATION > src/arch/arm/isa/formats/unimp.isa 8fc6e7a835d1 > src/arch/arm/isa/formats/unknown.isa 8fc6e7a835d1 > > Diff: http://reviews.gem5.org/r/2567/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
