----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2611/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10671:94bc71e83168 --------------------------- cpu: Tidy up the MemTest and make false sharing more obvious The MemTest class really only tests false sharing, and as such there was a lot of old cruft that could be removed. This patch cleans up the tester, and also makes it more clear what the assumptions are. As part of this simplification the reference functional memory is also removed. The regression configs using MemTest are updated to reflect the changes, and the stats will be bumped in a separate patch. The example config will be updated in a separate patch due to more extensive re-work. In a follow-on patch a new tester will be introduced that uses the MemChecker to implement true sharing. Diffs ----- configs/example/memtest.py a6fe75e8296b src/cpu/testers/memtest/MemTest.py a6fe75e8296b src/cpu/testers/memtest/memtest.hh a6fe75e8296b src/cpu/testers/memtest/memtest.cc a6fe75e8296b tests/configs/memtest-filter.py a6fe75e8296b tests/configs/memtest-ruby.py a6fe75e8296b tests/configs/memtest.py a6fe75e8296b Diff: http://reviews.gem5.org/r/2611/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
