----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2617/#review5788 -----------------------------------------------------------
Please rather make sure that responses are sunk before generating requests (i.e. do not call sendTimingReq as part of recvTimingResp). That is what I did for the X86 table walker. Would that be ok? - Andreas Hansson On Jan. 26, 2015, 8:28 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2617/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 8:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10667:b87ca279e34d > --------------------------- > mem: Fix race condition in crossbar routing table > > The routing table in the corssbar needs to be updated before the > request response is sent. Otherwise, the requestor may delete the > current request and allocate a new one, causing an address alias > in the routing table. > > > Diffs > ----- > > src/mem/coherent_xbar.cc bd376adfb7d4 > > Diff: http://reviews.gem5.org/r/2617/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
