----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2661/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10719:857838bcc36e --------------------------- mem: Move crossbar default latencies to subclasses This patch introduces a few subclasses to the CoherentXBar and NoncoherentXBar to distinguish the different uses in the system. We use the crossbar in a wide range of places: interfacing cores to the L2, as a system interconnect, connecting I/O and peripherals, etc. Needless to say, these crossbars have very different performance, and the clock frequency alone is not enough to distinguish these scenarios. Instead of trying to capture every possible case, this patch introduces dedicated subclasses for the three primary use-cases: L2XBar, SystemXBar and IOXbar. More can be added if needed, and the defaults can be overridden. Diffs ----- configs/common/CacheConfig.py c6cb94a14fea configs/common/FSConfig.py c6cb94a14fea configs/dram/sweep.py c6cb94a14fea configs/example/memcheck.py c6cb94a14fea configs/example/memtest.py c6cb94a14fea configs/example/ruby_mem_test.py c6cb94a14fea configs/example/se.py c6cb94a14fea configs/ruby/Ruby.py c6cb94a14fea configs/splash2/cluster.py c6cb94a14fea configs/splash2/run.py c6cb94a14fea src/cpu/BaseCPU.py c6cb94a14fea src/mem/XBar.py c6cb94a14fea tests/configs/base_config.py c6cb94a14fea tests/configs/memtest-filter.py c6cb94a14fea tests/configs/memtest.py c6cb94a14fea tests/configs/o3-timing-mp-ruby.py c6cb94a14fea tests/configs/o3-timing-ruby.py c6cb94a14fea tests/configs/simple-atomic-mp-ruby.py c6cb94a14fea tests/configs/tgen-dram-ctrl.py c6cb94a14fea tests/configs/tgen-simple-mem.py c6cb94a14fea Diff: http://reviews.gem5.org/r/2661/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
