> On Feb. 25, 2015, 4:32 p.m., Steve Reinhardt wrote: > > Took me longer to review this just because I'm not sure what to think of > > it. It's not pretty, but I don't have better ideas, so it's hard to object. > > > > One thing that bothers me is that, while it's noble to try and generalize > > things, despite the generic-sounding "--external-memory-system" switch, > > many of the low-level details seem very sst-specific (like > > 'port_type="sst"' as an obvious one). Would it be more appropriate just to > > call the option "--sst-memory"? > > > > Also, the ExternalCache thing looks like it should be a subclass, even > > though it's just a function. I can see how the function is more > > convenient, but making it a subclass would allow some better encapsulation > > of the cpu_side __getattr__/__setattr__ hack. > > > > These are just general thoughts though... I'm very interested in others' > > input. > > Curtis Dunham wrote: > There is some truth to this complaint. I think there is a little room > for improvement, though.
It's ready for another look at diff r5. - Curtis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/#review5914 ----------------------------------------------------------- On March 4, 2015, 1:07 a.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2668/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 1:07 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10709:a3b771cd744c > --------------------------- > config: Support full-system with SST's memory system > > This patch adds an example configuration in ext/sst/tests/ that allows > an SST/gem5 instance to simulate a 4-core AArch64 system with SST's > memHierarchy components providing all the caches and memories. > > > Diffs > ----- > > configs/common/CacheConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/FSConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/MemConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/Options.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/example/fs.py 8a20e2a1562debfc20b92be4581457c4147b3733 > ext/sst/tests/test6_arm_4c.py PRE-CREATION > src/dev/arm/RealView.py 8a20e2a1562debfc20b92be4581457c4147b3733 > > Diff: http://reviews.gem5.org/r/2668/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
