----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/#review5980 -----------------------------------------------------------
Looks much nicer. Thanks for the changes! Sorry for the long wait for the review. Nothing big, just could use a couple more comments I think. configs/common/CacheConfig.py <http://reviews.gem5.org/r/2668/#comment5218> a comment explaining the need/purpose for this class would be nice configs/common/CacheConfig.py <http://reviews.gem5.org/r/2668/#comment5219> please add a comment here explaining that there is an assumption being made on how the external memory system names its ports ext/sst/tests/test6_arm_4c.py <http://reviews.gem5.org/r/2668/#comment5217> so does this require you to edit the file to replace "/XXX/abs-path-to"? couldn't this path be read from an environment variable, or perhaps you could leave it as a relative path so it would work if you ran from the "gem5" directory? - Steve Reinhardt On March 3, 2015, 5:07 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2668/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 5:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10709:a3b771cd744c > --------------------------- > config: Support full-system with SST's memory system > > This patch adds an example configuration in ext/sst/tests/ that allows > an SST/gem5 instance to simulate a 4-core AArch64 system with SST's > memHierarchy components providing all the caches and memories. > > > Diffs > ----- > > configs/common/CacheConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/FSConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/MemConfig.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/common/Options.py 8a20e2a1562debfc20b92be4581457c4147b3733 > configs/example/fs.py 8a20e2a1562debfc20b92be4581457c4147b3733 > ext/sst/tests/test6_arm_4c.py PRE-CREATION > src/dev/arm/RealView.py 8a20e2a1562debfc20b92be4581457c4147b3733 > > Diff: http://reviews.gem5.org/r/2668/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
