> On April 1, 2015, 6:30 p.m., Steve Reinhardt wrote: > > Overall, I'm really glad to see this, especially since it doesn't impact > > performance. Much cleaner! > > > > Is there a plan to move the cache_impl.hh code to cache.cc now that it's > > not templated?
mercurial is not good at changes and renames, so to be able to actually see what is changed we are doing it this way. A follow on patch will do the impl.hh -> .cc > On April 1, 2015, 6:30 p.m., Steve Reinhardt wrote: > > src/mem/cache/cache.hh, line 75 > > <http://reviews.gem5.org/r/2711/diff/1/?file=44364#file44364line75> > > > > do we still need this? seems like a good opportunity to do > > s/BlkType/CacheBlk/g That's certainly an option - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2711/#review6008 ----------------------------------------------------------- On March 30, 2015, 9:16 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2711/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 9:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10777:9f23af363f48 > --------------------------- > mem: Remove templates in cache model > > This patch changes the cache implementation to rely on virtual methods > rather than using the replacement policy as a template argument. > > There is no impact on the simulation performance, and overall the > changes make it easier to modify (and subclass) the cache and/or > replacement policy. > > > Diffs > ----- > > src/mem/cache/base.cc 8a7285d6197e > src/mem/cache/blk.hh 8a7285d6197e > src/mem/cache/cache.hh 8a7285d6197e > src/mem/cache/cache.cc 8a7285d6197e > src/mem/cache/cache_impl.hh 8a7285d6197e > src/mem/cache/tags/base.hh 8a7285d6197e > src/mem/cache/tags/base_set_assoc.hh 8a7285d6197e > src/mem/cache/tags/base_set_assoc.cc 8a7285d6197e > src/mem/cache/tags/fa_lru.hh 8a7285d6197e > src/mem/cache/tags/lru.hh 8a7285d6197e > src/mem/cache/tags/lru.cc 8a7285d6197e > src/mem/cache/tags/fa_lru.cc 8a7285d6197e > src/mem/cache/tags/random_repl.cc 8a7285d6197e > src/mem/cache/tags/random_repl.hh 8a7285d6197e > > Diff: http://reviews.gem5.org/r/2711/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
