----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2711/#review6014 -----------------------------------------------------------
src/mem/cache/cache.hh <http://reviews.gem5.org/r/2711/#comment5245> should be VisitorFnPtr (since it's a type) - Steve Reinhardt On April 2, 2015, 2:09 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2711/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 2:09 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10777:7a17ca9141fb > --------------------------- > mem: Remove templates in cache model > > This patch changes the cache implementation to rely on virtual methods > rather than using the replacement policy as a template argument. > > There is no impact on the simulation performance, and overall the > changes make it easier to modify (and subclass) the cache and/or > replacement policy. > > > Diffs > ----- > > src/mem/cache/base.cc 8a7285d6197e > src/mem/cache/blk.hh 8a7285d6197e > src/mem/cache/cache.hh 8a7285d6197e > src/mem/cache/cache.cc 8a7285d6197e > src/mem/cache/cache_impl.hh 8a7285d6197e > src/mem/cache/tags/base.hh 8a7285d6197e > src/mem/cache/tags/base_set_assoc.hh 8a7285d6197e > src/mem/cache/tags/base_set_assoc.cc 8a7285d6197e > src/mem/cache/tags/fa_lru.hh 8a7285d6197e > src/mem/cache/tags/fa_lru.cc 8a7285d6197e > src/mem/cache/tags/lru.hh 8a7285d6197e > src/mem/cache/tags/lru.cc 8a7285d6197e > src/mem/cache/tags/random_repl.hh 8a7285d6197e > src/mem/cache/tags/random_repl.cc 8a7285d6197e > > Diff: http://reviews.gem5.org/r/2711/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
