----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2725/#review6017 -----------------------------------------------------------
I'm for removing this code. However, this patch needs to be pushed first: http://reviews.gem5.org/r/2702/ since in the current state restoring a checkpoint with Ruby is broken. - Jason Power On April 2, 2015, 9:31 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2725/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 9:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10790:2db4eeebab53 > --------------------------- > mem: Remove RubyMemoryControl and rely on DRAMCtrl > > This patch aims to ease maintenance and avoid confusion when it comes > to DRAM modelling in gem5. The DRAMCtrl model is fast, accurate, > integrated with power models, and covers a wide range of DRAM > variants. Thus, there is really no need to keep the RubyMemoryControl. > > > Diffs > ----- > > src/mem/ruby/structures/RubyMemoryControl.hh 8a7285d6197e > src/mem/ruby/structures/RubyMemoryControl.cc 8a7285d6197e > src/mem/ruby/structures/RubyMemoryControl.py 8a7285d6197e > src/mem/ruby/structures/SConscript 8a7285d6197e > > Diff: http://reviews.gem5.org/r/2725/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
