----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2725/#review6019 -----------------------------------------------------------
Instead of abruptly removing the RubyMemoryControl, can we just deprecate it and add a warning that it will eventually be removed (or at a specific time in the future)? In addition to existing gem5-gpu code and my personal patches, I'm aware of at least one other group that has pretty significant code that depends on the RubyMemoryControl. Migrating code to the new controllers is likely to involve some non-trivial dev+debug. Note: I suspect this code removal request is a bit different from the InOrderCPU removal request, since the RubyMemoryControl is a single component that has been a basis for a few memory controller optimization studies. - Joel Hestness On April 2, 2015, 9:31 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2725/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 9:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10790:2db4eeebab53 > --------------------------- > mem: Remove RubyMemoryControl and rely on DRAMCtrl > > This patch aims to ease maintenance and avoid confusion when it comes > to DRAM modelling in gem5. The DRAMCtrl model is fast, accurate, > integrated with power models, and covers a wide range of DRAM > variants. Thus, there is really no need to keep the RubyMemoryControl. > > > Diffs > ----- > > src/mem/ruby/structures/RubyMemoryControl.hh 8a7285d6197e > src/mem/ruby/structures/RubyMemoryControl.cc 8a7285d6197e > src/mem/ruby/structures/RubyMemoryControl.py 8a7285d6197e > src/mem/ruby/structures/SConscript 8a7285d6197e > > Diff: http://reviews.gem5.org/r/2725/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
