changeset 16643e7b322a in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=16643e7b322a
description:
x86: fix debug trace output for mwait
When running with the Exec flag, the mwait instruction attempted
to print out its source registers, which were never actually
initialized. This led to sporadic assertion failures when the
value stored there was invalid.
Committed by: Nilay Vaish <[email protected]>
diffstat:
src/arch/x86/isa/formats/monitor_mwait.isa | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diffs (15 lines):
diff -r 8a7285d6197e -r 16643e7b322a src/arch/x86/isa/formats/monitor_mwait.isa
--- a/src/arch/x86/isa/formats/monitor_mwait.isa Fri Mar 27 04:56:10
2015 -0400
+++ b/src/arch/x86/isa/formats/monitor_mwait.isa Fri Apr 03 11:42:10
2015 -0500
@@ -112,9 +112,9 @@
{
std::stringstream response;
+ // Although mwait could take hints from eax and ecx, the _srcRegIdx
+ // is not set, and thus should not be printed here
printMnemonic(response, mnemonic);
- ccprintf(response, " ");
- printReg(response, _srcRegIdx[0], machInst.opSize);
return response.str();
}
}};
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
