> On April 18, 2015, 8:19 p.m., Steve Reinhardt wrote: > > Although I agree that the name "divide-by-zero" is not the most clearly > > descriptive, that is the name of the exception in the x86 architecture (see > > for example http://wiki.osdev.org/Exceptions, or Table 2-1 of Vol 3 of the > > AMD64 Architecture Programmer's Manual. If you think it needs more > > comments to explain this discrepancy, that's fine, but I think we should > > keep the exception names consistent with the architecture definition. > > Joel Hestness wrote: > While I think we should leave the AMD naming, it's probably worth > noting/commenting that Intel calls the 0 (#DE) exception a "divide error" in > their documentation. http://www.intel.com/Assets/en_US/PDF/manual/253668.pdf, > http://ensiwiki.ensimag.fr/images/0/09/4MMPS_traps.pdf
Thanks for pointing this out, Joel... I looked at the AMD docs then went to see if that was consistent with other usage, saw the osdev.org page, and took that as confirmation that this was common. In practice, it looks like 3rd-party sites are split between the Intel and the AMD terminology. I'm fine with renaming this DivideError to follow the Intel naming. DivisionError doesn't seem consistent with anything else though. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2742/#review6053 ----------------------------------------------------------- On April 17, 2015, 1:30 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2742/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 1:30 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10789:42ef8fb0d914 > --------------------------- > x86: change divide-by-zero fault to division-error > Same exception is raised whether division with zero is performed or the > quotient is greater than the maximum value that the provided space can hold. > > > Diffs > ----- > > src/arch/x86/faults.hh d1df075f3b71 > src/arch/x86/isa/microops/regop.isa d1df075f3b71 > > Diff: http://reviews.gem5.org/r/2742/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
