> On April 20, 2015, 11:17 a.m., Steve Reinhardt wrote: > > Works for me. Thanks, Nilay!
Actually, now that I said that, you should update the commit message too (since it still says "division-error"). It would be nice to mention that this is the Intel terminology. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2742/#review6062 ----------------------------------------------------------- On April 20, 2015, 9:42 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2742/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 9:42 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10789:2e0a032f82e0 > --------------------------- > x86: change divide-by-zero fault to division-error > Same exception is raised whether division with zero is performed or the > quotient is greater than the maximum value that the provided space can hold. > > > Diffs > ----- > > src/arch/x86/faults.hh d1df075f3b71 > src/arch/x86/isa/microops/regop.isa d1df075f3b71 > > Diff: http://reviews.gem5.org/r/2742/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
