----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2741/#review6056 -----------------------------------------------------------
src/arch/arm/ArmSystem.py (line 94) <http://reviews.gem5.org/r/2741/#comment5258> Could you create a new intermediate class for both FreeBSD and Linux? Right now this is all duplicated and I'd really prefer to not have the duplication src/arch/arm/freebsd/freebsd.hh (line 264) <http://reviews.gem5.org/r/2741/#comment5259> I'd be surprised if these these are the same for Linux and FreeBSD. Similarly for the data structures below. Have you had a chance to compare them with the FreeBSD versions to check. They can be the source of odd and very difficult to find bugs in SE mode src/arch/arm/freebsd/process.cc (line 98) <http://reviews.gem5.org/r/2741/#comment5260> no tabs please src/arch/arm/freebsd/process.cc (line 1220) <http://reviews.gem5.org/r/2741/#comment5261> Done FreeBSD use these "private" syscalls like ARM AArch32 Linux does? src/arch/arm/freebsd/process.cc (line 1539) <http://reviews.gem5.org/r/2741/#comment5262> Is there any way some of this code could be put in the base class and shared between Linux and FreeBSD. Is it purely a subset of the Linux setup? If so, prehaps a function in the base class with an additional parameter specifying Linux (in which case nothing is done) or FreeBSD which if(!FreeBSD) is added to a few of the lines? Thanks Ruslan. This is getting a lot closer, and it will be great to have FreeBSD support in gem5. I have a couple questions above about code duplication between FreeBSD/Linux. Thanks again, Ali - Ali Saidi On April 19, 2015, 10:12 a.m., Ruslan Bukin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2741/ > ----------------------------------------------------------- > > (Updated April 19, 2015, 10:12 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This adds support for FreeBSD/aarch64 FS and SE mode (basic set of syscalls > only) > > > Diffs > ----- > > src/arch/arm/linux/process.hh d1df075f3b71 > src/arch/arm/linux/process.cc d1df075f3b71 > src/arch/arm/process.hh d1df075f3b71 > src/arch/arm/process.cc d1df075f3b71 > src/arch/generic/freebsd/threadinfo.hh PRE-CREATION > src/base/loader/elf_object.cc d1df075f3b71 > src/base/loader/object_file.hh d1df075f3b71 > src/base/output.cc d1df075f3b71 > src/base/vnc/vncserver.cc d1df075f3b71 > src/dev/arm/gic_pl390.cc d1df075f3b71 > src/dev/terminal.cc d1df075f3b71 > src/kern/SConscript d1df075f3b71 > src/kern/freebsd/events.hh PRE-CREATION > src/kern/freebsd/events.cc PRE-CREATION > src/kern/freebsd/freebsd.hh PRE-CREATION > src/sim/process.cc d1df075f3b71 > src/arch/arm/freebsd/freebsd.hh PRE-CREATION > src/arch/arm/freebsd/freebsd.cc PRE-CREATION > src/arch/arm/freebsd/process.hh PRE-CREATION > src/arch/arm/freebsd/process.cc PRE-CREATION > src/arch/arm/freebsd/system.hh PRE-CREATION > src/arch/arm/freebsd/system.cc PRE-CREATION > src/arch/arm/ArmSystem.py d1df075f3b71 > src/arch/arm/SConscript d1df075f3b71 > > Diff: http://reviews.gem5.org/r/2741/diff/ > > > Testing > ------- > > Tested on FreeBSD/amd64 host simulating FreeBSD/aarch64 (FS, SE) and > Linux/aarch64 (FS) > > > Thanks, > > Ruslan Bukin > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
